Skip to content

Treat Blank Lines As Leading/Trailing Trivia #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 25, 2024
Merged

Treat Blank Lines As Leading/Trailing Trivia #18

merged 26 commits into from
Jun 25, 2024

Conversation

bash
Copy link
Owner

@bash bash commented Jun 24, 2024 •
edited
Loading

Resolves #13

@bash bash force-pushed the newlines-as-trivia branch from 3786230 to f016f7c Compare June 24, 2024 14:23
@bash bash marked this pull request as ready for review June 24, 2024 18:28
@bash bash force-pushed the newlines-as-trivia branch from 302375a to 8033faa Compare June 25, 2024 09:02
bash added 20 commits June 25, 2024 11:26
@bash
Treat leading empty newlines as trivia
1cd5f57
@bash
Promote section header to a proper node
87eafcf
@bash
Rewrite internal helpers to use PeekRange / Read
c065f54
@bash
Separate peek / parse step
ba91956
@bash
Document how trivia works
da620e9
@bash
Test trailing trivia handling for all nodes
6b18102
@bash
Use PeekNextNodeType while parsing section children
121b7de
@bash
Treat trailing empty newlines as trivia
52b0367
@bash
Rename parameter
9294ff2
@bash
Fix parsing of section trailing trivia
ced516e
@bash
Auto-generate test data
a08cff7
@bash
Test and fix behaviour of trailing newlines for consecutive nodes
e98f6f8
@bash
Remove no longer needed detection of empty unrecognized nodes in editing
7830dc3
@bash
Rename test
c7a3896
@bash
Add example as test
f697aad
@bash
Refactoring
fc68bf0
@bash
Move to separate test class
f0d8bd6
@bash
Rename file to match type
1691a15
@bash
Break up parser into multiple files
7ba45f2
@bash
Improve naming
626cbdc
@bash bash force-pushed the newlines-as-trivia branch from e75b6df to 09703b8 Compare June 25, 2024 09:26
@bash bash force-pushed the newlines-as-trivia branch from 09703b8 to 2164772 Compare June 25, 2024 09:26
@bash bash force-pushed the newlines-as-trivia branch from 74e07cd to f1a08f2 Compare June 25, 2024 09:35
@bash bash merged commit 7c96d29 into main Jun 25, 2024
@bash bash deleted the newlines-as-trivia branch June 25, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty lines are recognized as an UnrecognizedIniNode
1 participant
@bash